Update contribution link and clarify encrypted field configuration. #4991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
reviewed
Jun 4, 2025
README.adoc
Outdated
| @@ -211,8 +211,9 @@ Now you are ready to build Spring Data MongoDB. Simply enter the following `mvnw | |||
|
|
|||
| If you want to build with the regular `mvn` command, you will need https://maven.apache.org/run-maven/index.html[Maven v3.8.0 or above]. | |||
|
|
|||
| _Also see link:CONTRIBUTING.adoc[CONTRIBUTING.adoc] if you wish to submit pull requests, and in particular, please sign | |||
| the https://cla.pivotal.io/sign/spring[Contributor’s Agreement] before your first non-trivial change._ | |||
| _Also see link:CONTRIBUTING.adoc[CONTRIBUTING.adoc] if you wish to submit pull requests. | |||
There was a problem hiding this comment.
Removing the Link to cla.pivotal.io is good, we have further details outlined on DCO at https://github.com/spring-projects/spring-data-build/blob/main/CONTRIBUTING.adoc so we should not add redundancy here.
ricardohsmello
force-pushed
the
update-docs-readme-and-encryption
branch
from
c3bfa5f to
3e3086d
Compare
Signed-off-by: Ricardo Mello <[email protected]>
Reconciled changes from main with the updated code sample that includes the required `keyId(...)` configuration for Queryable Encryption using the Range algorithm. Signed-off-by: Ricardo Mello <[email protected]>
ricardohsmello
force-pushed
the
update-docs-readme-and-encryption
branch
from
d61c9fd to
60107a8
Compare
|
Hi! All checks are now passing and the conflict has been resolved. Let me know if there's anything else I should adjust. Thanks again for the review! 😊 |
mp911de
added
type: documentation
| .queryable(encrypted(int32("age")).algorithm("Range"), range().contention(8).min(0).max(150)) | ||
| .encrypted(string("pin")) | ||
| .queryable(encrypted(int64("address.sign")).algorithm("Range"), range().contention(2).min(-10L).max(10L)) | ||
| .encrypted(int32("pin"), pinDK) |
There was a problem hiding this comment.
I'd prefer string to capture leading 0,
| @@ -161,16 +167,13 @@ class Patient { | |||
|
|
|||
| @Id String id; | |||
|
|
|||
| @Encrypted(algorithm = "Indexed") | |||
| @Encrypted(algorithm = "Indexed") // | |||
There was a problem hiding this comment.
we should not add slashes (to enforce line breaks) in documentation.
Comment on lines
-171
to
-173
| @Encrypted(algorithm = "Unindexed") | ||
| String pin; | ||
|
|
There was a problem hiding this comment.
Why remove the field here?
Comment on lines
-217
to
-221
| { | ||
| keyId: ..., | ||
| path: 'pin', | ||
| bsonType: 'string' | ||
| }, |
There was a problem hiding this comment.
Why remove the field here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated README.adoc to reflect the current contribution process, replacing the outdated CLA link with the new Developer Certificate of Origin (DCO) instructions.
In mongo-encryption.adoc, updated the code sample to include the required
keyId(...)call when configuring a field with Queryable Encryption.